lkml.org 
[lkml]   [2012]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] atl1c: dont use highprio tx queue
    From
    From: Eric Dumazet <eric.dumazet@gmail.com>
    Date: Thu, 16 Feb 2012 07:43:11 +0100

    > This driver attempts to use two TX rings but lacks proper support :
    >
    > 1) IRQ handler only takes care of TX completion on first TX ring
    > 2) the stop/start logic uses the legacy functions (for non multiqueue
    > drivers)
    >
    > This means all packets witk skb mark set to 1 are sent through high
    > queue but are never cleaned and queue eventualy fills and block the
    > device, triggering the infamous "NETDEV WATCHDOG" message.
    >
    > Lets use a single TX ring to fix the problem, this driver is not a real
    > multiqueue one yet.
    >
    > Minimal fix for stable kernels.
    >
    > Reported-by: Thomas Meyer <thomas@m3y3r.de>
    > Tested-by: Thomas Meyer <thomas@m3y3r.de>
    > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

    Applied.


    \
     
     \ /
      Last update: 2012-02-20 01:03    [W:0.020 / U:0.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site