lkml.org 
[lkml]   [2012]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err
From
Date
On Sat, 2012-02-18 at 09:40 +0300, Dan Carpenter wrote:
> On Fri, Feb 17, 2012 at 10:30:25PM -0800, Joe Perches wrote:
> > On Sat, 2012-02-18 at 09:25 +0300, Dan Carpenter wrote:
> > > On Fri, Feb 17, 2012 at 09:39:36PM -0200, Jorgyano Vieira wrote:
> > > > Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition.
> > > This needs a pr_fmt line so we can tell where the errors are coming
> > > from.
> > > #define pr_fmt(fmt) KBUILD_MODNAME ": %s:%d: " fmt, __func__, __LINE__
> > True.
> > __func__ and __LINE__ are not generally useful though.
> If you don't know the function and line number, then how do you
> tell all the "Invalid args" printks apart?

It's possible to add "%s...", __func__ to
the necessary uses. Adding it to the generic
is likely overkill.

But is it really necessary anyway?

Aren't those called via some specific notifier
such that the output would make sense given
some specific invalid input?




\
 
 \ /
  Last update: 2012-02-18 07:59    [W:0.654 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site