[lkml]   [2012]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 1/3] w1_bq27000: remove unnecessary NULL test.
    As recent change means that we now dereference 'dev' before testing
    for NULL.

    That means either the change was wrong, or the test isn't needed.
    As this function is only called from one driver (bq27x000_battery) and
    it always passed a non-NULL dev, it seems good to assume that the
    test isn't needed.

    So remove it.

    Reported-by: Dan Carpenter <>
    Signed-off-by: NeilBrown <>

    drivers/w1/slaves/w1_bq27000.c | 3 ---
    1 files changed, 0 insertions(+), 3 deletions(-)

    diff --git a/drivers/w1/slaves/w1_bq27000.c b/drivers/w1/slaves/w1_bq27000.c
    index 8f10fd2..50d9af7 100644
    --- a/drivers/w1/slaves/w1_bq27000.c
    +++ b/drivers/w1/slaves/w1_bq27000.c
    @@ -45,9 +45,6 @@ static int w1_bq27000_read(struct device *dev, unsigned int reg)
    u8 val;
    struct w1_slave *sl = container_of(dev->parent, struct w1_slave, dev);

    - if (!dev)
    - return 0;
    w1_write_8(sl->master, HDQ_CMD_READ | reg);
    val = w1_read_8(sl->master);

     \ /
      Last update: 2012-02-19 03:13    [W:0.018 / U:30.956 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site