lkml.org 
[lkml]   [2012]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/9] blkcg: drop unnecessary RCU locking
    Hello,

    On Fri, Feb 17, 2012 at 12:28:57PM -0500, Vivek Goyal wrote:
    > I am kind of confused that what are the semantics of calling
    > blkg_lookup_create(). Given the fact that it traverses the
    > blkcg->blkg_list which is rcu protected, so either we should have
    > rcu read lock held or we should have blkcg->lock held.

    Modifying blkgs require both blkcg and queue locks, so read access can
    be done holding any lock. Also, as modifications are done using RCU
    safe oprations, it can be looked up while holding RCU read lock.

    > > How?
    >
    > Can pre_destroy() and blkio_policy_parse_and_set() make progress in
    > parallel for same cgroup(blkcg) but different queue.
    >
    > If yes, blkg_lookup() might be doing blkg->q == q check and pre_destroy
    > might delete that group and free it up.

    And that's why __blkg_release() is RCU free'ing blkgs, no?

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-02-17 18:45    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site