lkml.org 
[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] sched: Remove rcu_read_lock/unlock() from select_idle_sibling()
    Date
    select_idle_sibling() is called from select_task_rq_fair(), which
    already has the RCU read lock held.

    Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
    ---

    kernel/sched/fair.c | 4 ----
    1 files changed, 0 insertions(+), 4 deletions(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index 4ab60a2..6ce9992 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -2670,8 +2670,6 @@ static int select_idle_sibling(struct task_struct *p, int target)
    /*
    * Otherwise, iterate the domains and find an elegible idle cpu.
    */
    - rcu_read_lock();
    -
    sd = rcu_dereference(per_cpu(sd_llc, target));
    for_each_lower_domain(sd) {
    sg = sd->groups;
    @@ -2693,8 +2691,6 @@ next:
    } while (sg != sd->groups);
    }
    done:
    - rcu_read_unlock();
    -
    return target;
    }



    \
     
     \ /
      Last update: 2012-02-17 04:07    [W:0.019 / U:91.724 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site