[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V2 1/2] mfd: Add driver for STA2X11 MFD block
On Thu, Feb 16, 2012 at 2:00 PM, Alessandro Rubini <> wrote:

> +config MFD_STA2X11
> +       bool "STA2X11 multi function device support"
> +       depends on STA2X11
> +       select MFD_CORE
> +       select GPIO_STA2X11

Note: this selects a non-existent driver at this point. (OK no big deal.)

> +/* Give names to GPIO pins, like PXA does, taken from the manual */
> +#define GPIO0                  0
> +#define GPIO1                  1
> +#define GPIO2                  2

These are too general names I think. It should be clear that this is the
GPIO number relative to this one controller, so I would prefix them
like STA2X11_GPIO0 etc.

Overall the MFD core for STA2X11 is looking pretty good!

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2012-02-16 20:31    [W:0.085 / U:11.688 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site