lkml.org 
[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V2 1/2] mfd: Add driver for STA2X11 MFD block
    From
    On Thu, Feb 16, 2012 at 2:00 PM, Alessandro Rubini <rubini@gnudd.com> wrote:

    > +config MFD_STA2X11
    > +       bool "STA2X11 multi function device support"
    > +       depends on STA2X11
    > +       select MFD_CORE
    > +       select GPIO_STA2X11

    Note: this selects a non-existent driver at this point. (OK no big deal.)

    > +/* Give names to GPIO pins, like PXA does, taken from the manual */
    > +#define GPIO0                  0
    > +#define GPIO1                  1
    > +#define GPIO2                  2
    (...)

    These are too general names I think. It should be clear that this is the
    GPIO number relative to this one controller, so I would prefix them
    like STA2X11_GPIO0 etc.

    Overall the MFD core for STA2X11 is looking pretty good!

    Yours,
    Linus Walleij
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-16 20:31    [W:0.025 / U:96.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site