lkml.org 
[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite()
From
Date
On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote:
> CC: Sage Weil <sage@newdream.net>
> CC: ceph-devel@vger.kernel.org
> Signed-off-by: Jan Kara <jack@suse.cz>


This will update the timestamp even if a write
fault fails, which is different from before.

Hard to avoid though.

Looks good to me.

Signed-off-by: Alex Elder <elder@dreamhost.com>

> fs/ceph/addr.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 173b1d2..12b139f 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1181,6 +1181,9 @@ static int ceph_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
> loff_t size, len;
> int ret;
>
> + /* Update time before taking page lock */
> + file_update_time(vma->vm_file);
> +
> size = i_size_read(inode);
> if (off + PAGE_CACHE_SIZE <= size)
> len = PAGE_CACHE_SIZE;





\
 
 \ /
  Last update: 2012-02-16 20:07    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site