lkml.org 
[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/3] fadvise: implement POSIX_FADV_NOREUSE
On 2/16/12 2:39 AM, Andrea Righi wrote:

> Arun, thank you very much for your review and testing. Probably we'll
> move to a different, memcg-based solution, so I don't think I'll post
> another version of this patch set as is. In case, I'll apply one of
> the workarounds for the rb_root attribute.

I'm not sure if the proposed memory.file.limit_in_bytes is the right
interface. Two problems:

* The user is now required to figure out what is the right amount of
page cache for the app (may change over time)

* If the app touches two sets of files, one with streaming access and
the other which benefits from page cache (eg: a mapper task in a map
reduce), memcg doesn't allow the user to specify the access pattern per-fd.

-Arun



\
 
 \ /
  Last update: 2012-02-16 19:45    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site