Messages in this thread | | | Subject | Re: [PATCHv5 0/8] perf tool: parser generator for events parsing | From | Peter Zijlstra <> | Date | Thu, 16 Feb 2012 18:03:03 +0100 |
| |
On Thu, 2012-02-16 at 13:00 +0100, Jiri Olsa wrote: > hi, > here's new version of event parsing patchset. > > I saw Arnaldo already sent patches 1-3 to Ingo, but they did not make it > to the tree yet, so I'm still attaching them here. > > v5 changes: > 4/8 - patch updated by Peter with actual format definitions > for x86 processors > 6/8 - added hardcoded terms for config[12] and sample_period > the code is ready to include branch_sample_type once > this field is available in perf_event_attr, just > uncommenting one line.. ;) > - allow config option to be used without value in which > case 1 is assigned as value > > Overall summarize: > - adding event parser bison/flex generator > - the event syntax stays as it was > - adding event format sysfs group attribute > for pmu device > - adding new syntax to specify raw events based > on the sysfs pmu's format attribute > eg. "cpu/config=1,config1=2,config2=3/u" > > Attached patches: > 1/8 perf, tool: Remove unused functions from debugfs object > 2/8 perf, tool: Add sysfs mountpoint interface > 3/8 perf, tool: Add bitmap_or function into bitmap object > 4/8 perf: Adding sysfs group format attribute for pmu device > 5/8 perf, tool: Add parser generator for events parsing > 6/8 perf, tool: Add config options support for event parsing > 7/8 perf, tool: Add perf pmu object to access pmu format definition > 8/8 perf, tool: Add support to specify pmu style event
I'm fine with this going fwd, and since this is mostly tools/perf I suggest acme take it, so:
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Also, it might make sense to CC everybody who has/maintains a hardware pmu implementation on patch 4.
Thanks Jiri!
| |