lkml.org 
[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 10/11] nfs: Push file_update_time() into nfs_vm_page_mkwrite()
    Date
    On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote:
    > CC: Trond Myklebust <Trond.Myklebust@netapp.com>
    > CC: linux-nfs@vger.kernel.org
    > Signed-off-by: Jan Kara <jack@suse.cz>
    > ---
    > fs/nfs/file.c | 3 +++
    > 1 files changed, 3 insertions(+), 0 deletions(-)
    >
    > diff --git a/fs/nfs/file.c b/fs/nfs/file.c
    > index c43a452..2407922 100644
    > --- a/fs/nfs/file.c
    > +++ b/fs/nfs/file.c
    > @@ -525,6 +525,9 @@ static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
    > /* make sure the cache has finished storing the page */
    > nfs_fscache_wait_on_page_write(NFS_I(dentry->d_inode), page);
    >
    > + /* Update file times before taking page lock */
    > + file_update_time(filp);
    > +
    > lock_page(page);
    > mapping = page->mapping;
    > if (mapping != dentry->d_inode->i_mapping)

    Hi Jan,

    file_update_time() is a no-op in NFS, since we set S_NOATIME|S_NOCMTIME
    on all inodes.

    Cheers
    Trond

    --
    Trond Myklebust
    Linux NFS client maintainer

    NetApp
    Trond.Myklebust@netapp.com
    www.netapp.com

    \
     
     \ /
      Last update: 2012-02-16 14:53    [W:3.612 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site