Messages in this thread | | | Subject | Re: [PATCH RFC tip/core/rcu] rcu: direct algorithmic SRCU implementation | From | Peter Zijlstra <> | Date | Thu, 16 Feb 2012 12:51:55 +0100 |
| |
On Thu, 2012-02-16 at 06:00 -0500, Mathieu Desnoyers wrote: > This brings the following question then: which memory barriers, in the > scheduler activity, act as full memory barriers to migrated threads ? I > see that the rq_lock is taken, but this lock is permeable in one > direction (operations can spill into the critical section). I'm probably > missing something else, but this something else probably needs to be > documented somewhere, since we are doing tons of assumptions based on > it.
A migration consists of two context switches, one switching out the task on the old cpu, and one switching in the task on the new cpu.
Now on x86 all the rq->lock grabbery is plenty implied memory barriers to make anybody happy.
But I think, since there's guaranteed order (can't switch to before switching from) you can match the UNLOCK from the switch-from to the LOCK from the switch-to to make your complete MB.
Does that work or do we need more?
| |