Messages in this thread | | | Date | Thu, 16 Feb 2012 12:59:43 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 3/3] KVM: perf: kvm events analysis tool |
| |
On 02/13/2012 11:52 PM, David Ahern wrote:
>> The first patch is only needed for code compilation, after kvm-events is >> compiled, you can analyse any kernels. :) > > understood. > > Now that I recall perf's way of handling out of tree builds, a couple of > comments: > > 1. you need to add the following to tools/perf/MANIFEST > arch/x86/include/asm/svm.h > arch/x86/include/asm/vmx.h > arch/x86/include/asm/kvm_host.h >
Right.
> 2.scripts/checkpatch.pl is an unhappy camper. >
It seems checkpath always complains about TRACE_EVENT and many more than-80-characters lines in perf tools.
> I'll take a look at the code and try out the command when I get some time. >
Okay, i will post the next version after collecting your new comments!
Thanks for your time, David! :)
| |