lkml.org 
[lkml]   [2012]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH block/for-linus 1/3] block: replace icq->changed with icq->flags
On 2012-02-15 02:09, Shaohua Li wrote:
> 2012/2/15 Tejun Heo <tj@kernel.org>:
>> icq->changed was used for ICQ_*_CHANGED bits. Rename it to flags and
>> access it under ioc->lock instead of using atomic bitops.
>> ioc_get_changed() is added so that the changed part can be fetched and
>> cleared as before.
>>
>> icq->flags will be used to carry other flags.
>>
>> Signed-off-by: Tejun Heo <tj@kernel.org>
>> ---
>> Jens, these three patches are to fix the swap heavy workload
>> regression reported by Shaohua.
>>
>> Shaohua, I ended up changing the second patch, which shouldn't change
>> anything but it would be great if you can verify this series once
>> more.
> yes, confirmed the patches fix the regression. Thanks for fixing it.
> Tested-by: Shaohua Li <shaohua.li@intel.com>

Great, thanks Tejun - and Shaohua for finding/reporting/testing. I'll
get this applied.

--
Jens Axboe



\
 
 \ /
  Last update: 2012-02-15 09:45    [W:0.044 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site