lkml.org 
[lkml]   [2012]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Return proper error code from register_kprobe()
On Wed, 15 Feb 2012 12:46:03 +0530
Prashanth Nageshappa <prashanth@linux.vnet.ibm.com> wrote:

> register_kprobe() aborts if the address of the new request falls in a
> prohibited area (such as ftrace pouch, __kprobes annotated functions,

I'm sitting here wondering what you meant to type when you typed
"ftrace pouch". I'm stumped! But you're not allowed to tell us - that
would take all the fun out of it.

> non-kernel text addresses, jump label text). We however don't return the
> right error on this abort, resulting in a silent failure - incorrect
> adding/reporting of kprobes ('perf probe do_fork+18' or
> 'perf probe mcount' for instance).
>
> In V2 we are incorporating Masami Hiramatsu's feedback.
>
> This patch fixes it by returning -EINVAL upon failure.
>
> While we are here, rename the label used for exit to be more appropriate.
>
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Signed-off-by: Prashanth K Nageshappa <prashanth@linux.vnet.ibm.com>
> Cc: stable@vger.kernel.org

So we want this for 3.3 with a -stable backport.


\
 
 \ /
  Last update: 2012-02-15 22:25    [W:0.040 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site