lkml.org 
[lkml]   [2012]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH UPDATED block/for-linus] block: blk-throttle should be drained regardless of q->elevator
On 2012-02-14 02:14, Tejun Heo wrote:
> Currently, blk_cleanup_queue() doesn't call elv_drain_elevator() if
> q->elevator doesn't exist; however, bio based drivers don't have
> elevator initialized but can still use blk-throttle. This patch moves
> q->elevator test inside blk_drain_queue() such that only
> elv_drain_elevator() is skipped if !q->elevator.
>
> -v2: loop can have registered queue which has NULL request_fn. Make
> sure we don't call into __blk_run_queue() in such cases.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Vivek Goyal <vgoyal@redhat.com>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> Added check against NULL q->request_fn for loop driver. Thanks.

Applied, thanks.

--
Jens Axboe



\
 
 \ /
  Last update: 2012-02-15 17:01    [from the cache]
©2003-2011 Jasper Spaans