lkml.org 
[lkml]   [2012]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] x86, reschedule: check to see if system is shutting down
From
Date
On Wed, 2012-02-15 at 09:54 -0500, Don Zickus wrote:
> On Wed, Feb 15, 2012 at 12:26:37PM +0100, Peter Zijlstra wrote:
> >
> > Right, so this fixes this one particular case, I imagine there's tons of
> > places that could go splat due to this (but don't quite yet for some
> > reason).
> >
> > We can't go around annotating everything, nor would we want to simply
> > shut up all warnings for fear of missing an actual error.
> >
> > Why can't the normal shut-down path use a less crazy approach to going
> > down?
>
> Well maybe it can, it's been like that way for over three years now. I'm
> surprised no one ran into issues before now.
>
> The only thing I can think that would work is stop_machine(). Pass in a
> halt function and a cpumask of everyone but smp_processor_id(). That
> would solve the problem, no?

nope.. same problem, you're not telling anybody you're shooting CPUs
down -- this telling is usually done through cpu hotplug notifiers that
fix up state.

The only way is to unplug all cpus except the one. Problem with that is
that we cannot (as of yet) unplug the boot cpu.


\
 
 \ /
  Last update: 2012-02-15 15:59    [W:0.113 / U:0.052 seconds]
©2003-2014 Jasper Spaans. Advertise on this site