Messages in this thread Patch in this message |  | | | Subject | Re: [PATCH 3.3 v2] I2C: OMAP: fix build breakage when CONFIG_OF is not set | | From | Luciano Coelho <> | | Date | Tue, 14 Feb 2012 11:55:31 +0200 |
| |
Hi Ben,
On Mon, 2012-02-13 at 23:27 +0000, Ben Dooks wrote: > On Wed, Feb 08, 2012 at 01:18:21PM +0200, Luciano Coelho wrote: > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > > index f713eac..fd200eb 100644 > > --- a/drivers/i2c/busses/i2c-omap.c > > +++ b/drivers/i2c/busses/i2c-omap.c > > @@ -979,6 +979,8 @@ static const struct of_device_id omap_i2c_of_match[] = { > > { }, > > }; > > MODULE_DEVICE_TABLE(of, omap_i2c_of_match); > > +#else > > +static const struct of_device_id *omap_i2c_of_match = NULL; > > #endif > > of_match_ptr(_ptr) will go to NULL if CONFIG_OF is not set, use that please.
Yes, you're right. But this patch can be ignored, since there was already an equivalent one queued up (which I missed). And it uses of_match_ptr() ;)
Thanks for your comment anyway!
-- Cheers, Luca.
|  |