Messages in this thread Patch in this message | | | From | Yang Bai <> | Subject | [PATCH] slab: warning if total alloc size overflow | Date | Tue, 14 Feb 2012 15:28:19 +0800 |
| |
Before, if the total alloc size is overflow, we just return NULL like alloc fail. But they are two different type problems. The former looks more like a programming problem. So add a warning here.
Signed-off-by: Yang Bai <hamo.by@gmail.com> --- include/linux/slab.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/include/linux/slab.h b/include/linux/slab.h index 573c809..5865237 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -242,8 +242,10 @@ size_t ksize(const void *); */ static inline void *kcalloc(size_t n, size_t size, gfp_t flags) { - if (size != 0 && n > ULONG_MAX / size) + if (size != 0 && n > ULONG_MAX / size) { + WARN(1, "Alloc memory size (%lu * %lu) overflow.", n, size); return NULL; + } return __kmalloc(n * size, flags | __GFP_ZERO); } -- 1.7.9
| |