Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 3/6] usermodehelper: kill umh_wait, renumber UMH_* constants | Date | Wed, 15 Feb 2012 11:39:17 +1030 |
| |
On Tue, 14 Feb 2012 17:48:21 +0100, Oleg Nesterov <oleg@redhat.com> wrote: > No functional changes. It is not sane to use UMH_KILLABLE with > enum umh_wait, but obviously we do not want another argument in > call_usermodehelper_* helpers. Kill this enum, use the plain int.
Seems like a step backwards. Perhaps reorder the enum, but implying an explicit range of values explicit by using an enum seems good.
But it's a minor gripe, feel free to ignore.
Entire series: Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks for this! Rusty.
| |