lkml.org 
[lkml]   [2012]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/6 v4] memcg: remove EXPORT_SYMBOL(mem_cgroup_update_page_stat)
    On Mon, Feb 13, 2012 at 7:06 PM, KAMEZAWA Hiroyuki
    <kamezawa.hiroyu@jp.fujitsu.com> wrote:
    >
    > This is just a cleanup.
    > ==
    > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > Date: Thu, 2 Feb 2012 12:05:41 +0900
    > Subject: [PATCH 1/6] memcg: remove EXPORT_SYMBOL(mem_cgroup_update_page_stat)
    >
    > From the log, I guess EXPORT was for preparing dirty accounting.
    > But _now_, we don't need to export this. Remove this for now.
    >
    > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

    Looks good to me.

    Reviewed-by: Greg Thelen <gthelen@google.com>

    > ---
    >  mm/memcontrol.c |    1 -
    >  1 files changed, 0 insertions(+), 1 deletions(-)
    >
    > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
    > index ab315ab..4c2b759 100644
    > --- a/mm/memcontrol.c
    > +++ b/mm/memcontrol.c
    > @@ -1897,7 +1897,6 @@ out:
    >                move_unlock_page_cgroup(pc, &flags);
    >        rcu_read_unlock();
    >  }
    > -EXPORT_SYMBOL(mem_cgroup_update_page_stat);
    >
    >  /*
    >  * size of first charge trial. "32" comes from vmscan.c's magic value.
    > --
    > 1.7.4.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-14 08:23    [W:0.039 / U:0.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site