Messages in this thread | | | Date | Tue, 14 Feb 2012 19:23:00 +0000 | From | Matthew Garrett <> | Subject | Re: [PATCH V3] kmsg_dump: Don't run on non-error paths by default |
| |
On Fri, Feb 10, 2012 at 10:45:15AM -0500, Matthew Garrett wrote: > Since 04c6862c055fb687c90d9652f32c11a063df15cf kmsg_dump() gets run on > normal paths including poweroff and reboot. This is less than ideal given > pstore implementations that can only represent single backtraces, since a > reboot may overwrite a stored oops before it's been picked up by userspace. > In addition, some pstore backends may have low performance and provide a > significant delay in reboot as a result. > > This patch adds a printk.always_kmsg_dump kernel parameter (which can also > be changed from userspace). Without it, the code will only be run on > failure paths rather than on normal paths. The option can be enabled in > environments where there's a desire to attempt to audit whether or not > a reboot was cleanly requested or not.
Anyone? Whose tree should this go through?
-- Matthew Garrett | mjg59@srcf.ucam.org
| |