| From | David Howells <> | Subject | Re: [PATCH 21/21] posix_types: Remove fd_set macros | Date | Tue, 14 Feb 2012 19:18:34 +0000 |
| |
Tony Luck <tony.luck@intel.com> wrote:
> Adding a #include <linux/string.h> to include/linux/time.h fixes them for me.
Which is one of the reasons I'd rather not see these things cropping up in linux/time.h. Either put them in linux/select.h (mirroring userspace) or stick them in linux/poll.h with the rest of the polling paraphernalia.
__FD_SET() and co aren't exported to userspace anyway, as I understand it, so it shouldn't hurt to bung them in linux/poll.h, and if they are exported to userspace, they should stay in posix_types.h, shouldn't they?
To support this, at least three #includes will have to be added to linux/time.h: linux/posix_types.h (which is fair enough), linux/bitops.h and linux/string.h.
David
|