[lkml]   [2012]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Ensure that walk_page_range()'s start and end are page-aligned
    DR> That's not a precedent, there's a big difference between the
    DR> performance of gup_fast(), where we can't spare an additional
    DR> compare and branch, and walk_page_range(). VM_BUG_ON() is typically
    DR> used in situations where a debug kernel has been built, including
    DR> CONFIG_DEBUG_VM, and the check helps to isolate a problem that would
    DR> be otherwise difficult to find.

    Okay, fair enough. I was trying to stay in line with the other
    conventions, knowing that the check would only be done with
    CONFIG_DEBUG_VM enabled.

    I'd rather just make it always do the check in walk_page_range(). Does
    that sound reasonable?

    Dan Smith
    IBM Linux Technology Center

     \ /
      Last update: 2012-02-14 16:03    [W:0.021 / U:23.256 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site