lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] HID: use generic driver for Logitech Unifying receivers if CONFIG_HID_LOGITECH_DJ=n
    Hi Konstantin,

    This was the original implementation
    http://www.spinics.net/lists/linux-input/msg15225.html
    Jiri suggested we removed the conditional compilation and we accepted.

    Which are your reasons to add those conditionals back again?

    Cheers,

    Nestor

    On Mon, Feb 13, 2012 at 9:06 AM, Konstantin Khlebnikov
    <khlebnikov@openvz.org> wrote:
    > Before commit 534a7b8e1 "HID: Add full support for Logitech Unifying receivers"
    > Logitech Unifying receiver can work as generic device without special driver,
    > after that commit these devices does not works without special driver.
    >
    > After this patch they will use generic driver if special driver is disabled.
    >
    > Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
    > ---
    >  drivers/hid/hid-core.c |    2 ++
    >  1 files changed, 2 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
    > index af08ce7..3d7a174 100644
    > --- a/drivers/hid/hid-core.c
    > +++ b/drivers/hid/hid-core.c
    > @@ -1462,8 +1462,10 @@ static const struct hid_device_id hid_have_special_driver[] = {
    >        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DFGT_WHEEL) },
    >        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G25_WHEEL) },
    >        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G27_WHEEL) },
    > +#if IS_ENABLED(CONFIG_HID_LOGITECH_DJ)
    >        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_UNIFYING_RECEIVER) },
    >        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_UNIFYING_RECEIVER_2) },
    > +#endif
    >        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WII_WHEEL) },
    >        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_RUMBLEPAD2) },
    >        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACETRAVELLER) },
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-13 09:43    [W:0.050 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site