lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Staging: bcm: Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()
On Sun, Feb 12, 2012 at 12:54:31AM +0100, Jesper Juhl wrote:
> On Fri, 10 Feb 2012, Greg KH wrote:
>
> > On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote:
> > > From: Jesper Juhl <jj@codesealer.com>
> > >
> > > We allocate memory for 'pstAddIndication' with kmalloc() in
> > > drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> > > neglect to free it on a number of exit paths from that function.
> > >
> > > This could probably be resolved cleaner/nicer, but this file needs a
> > > serious overhaul in any case, so I opted for just fixing the problem
> > > as directly as I could and then we can clean it up generally
> > > later... This at least makes it stop bleeding..
> > >
> > > Signed-off-by: Jesper Juhl <jj@codesealer.com>
> >
> > Odd, didn't I already apply this patch?
> >
> > confused,
> >
>
> Well, you were the one who (in email message with Message-ID:
> <20120209175217.GA13959@kroah.com>) said that it no longer applied and
> asked for a resubmit against linux-next:
>
> "This patch no longer applies, care to redo it against the latest
> linux-next tree?"
>
> So I just did what you asked :-)

Yes, but...

> Whether or not you have already applied it somewhere else I have no
> idea...

I tried to apply this, and it said it was already applied. So either I
already merged it, or someone else made the same patch, or you created
it reverted.

I'm confused, sorry.

greg k-h


\
 
 \ /
  Last update: 2012-02-14 05:19    [W:0.065 / U:0.860 seconds]
©2003-2014 Jasper Spaans. Advertise on this site