[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH V1 0/3] Support for open drain gpios in gpilib/fixed regulators.
    On Mon, Feb 13, 2012 at 7:29 AM, Laxman Dewangan <> wrote:

    > This is series of patches  to add support of the open drain gpios
    > in standard gpio library and using this in fixed regulators.
    > - Added GPIOF_OD flag so that client can request the gpio with this flag.
    > - Added support for the sysfs interface for open-drain.
    > - Handle open drain gpio configuration properly.
    > - Use this flag in fixed regualtor to tell that gpio is open drain.
    > - Gpio documentation changes to have support for open-drain.

    My gut feeling is that this stuff needs to go into pinctrl.

    The reason, which has been discussed when similar patches (from me,
    for example) were NACK:ed in the past, is that if we put in OD pin
    properties, we put in all pin properties (open source, drive strength,
    biasing pull-up/pull-down etc etc) and that is the reason to why the
    orthogonal pinctrl subsystem was created in the first place.

    So I'd opt for moving the driver you need to drivers/pinctrl and
    expose the gpiolib interface from there, while adding pinctrl
    on the side.

    Also, we had a flamefest a while back as to whether we should
    enumerate all config options (like OD, OS...) or have it all-custom,
    and I was sort of shot down on that. But I have a generic control patch
    set boiling so if you like that kind of stuff I'll respin it.

    Linus Walleij
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-02-13 21:05    [W:0.040 / U:27.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site