lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V1 3/3] regulator: fixed: Support for open-drain gpio
    Date
    Some of regulator switches like bidirectional load switches
    connected through the open drain gpios. As open drain gpios
    should not be driven to output with value of 1, it needs to
    handle differently to set the pin state to HIGH.
    Adding the flag to find out if gpio is open drain and pass
    this information to gpio library for handling open-drain gpio
    configuration accordingly.

    Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
    ---
    drivers/regulator/fixed.c | 29 +++++++++++++----------------
    include/linux/regulator/fixed.h | 7 +++++++
    2 files changed, 20 insertions(+), 16 deletions(-)

    diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
    index e24e3a1..d6c8d66 100644
    --- a/drivers/regulator/fixed.c
    +++ b/drivers/regulator/fixed.c
    @@ -199,7 +199,9 @@ static int __devinit reg_fixed_voltage_probe(struct platform_device *pdev)
    drvdata->startup_delay = config->startup_delay;

    if (gpio_is_valid(config->gpio)) {
    + int gpio_flag;
    drvdata->enable_high = config->enable_high;
    + drvdata->is_enabled = config->enabled_at_boot;

    /* FIXME: Remove below print warning
    *
    @@ -216,29 +218,24 @@ static int __devinit reg_fixed_voltage_probe(struct platform_device *pdev)
    dev_warn(&pdev->dev,
    "using GPIO 0 for regulator enable control\n");

    - ret = gpio_request(config->gpio, config->supply_name);
    - if (ret) {
    - dev_err(&pdev->dev,
    - "Could not obtain regulator enable GPIO %d: %d\n",
    - config->gpio, ret);
    - goto err_name;
    - }
    -
    - /* set output direction without changing state
    + /*
    + * set output direction without changing state
    * to prevent glitch
    */
    - drvdata->is_enabled = config->enabled_at_boot;
    - ret = drvdata->is_enabled ?
    - config->enable_high : !config->enable_high;
    + gpio_flag = drvdata->is_enabled ?
    + GPIOF_OUT_INIT_HIGH : GPIOF_OUT_INIT_LOW;
    +
    + if (config->gpio_is_open_drain)
    + gpio_flag |= GPIOF_OD;

    - ret = gpio_direction_output(config->gpio, ret);
    + ret = gpio_request_one(config->gpio, gpio_flag,
    + config->supply_name);
    if (ret) {
    dev_err(&pdev->dev,
    - "Could not configure regulator enable GPIO %d direction: %d\n",
    + "Could not obtain regulator enable GPIO %d: %d\n",
    config->gpio, ret);
    - goto err_gpio;
    + goto err_name;
    }
    -
    } else {
    /* Regulator without GPIO control is considered
    * always enabled
    diff --git a/include/linux/regulator/fixed.h b/include/linux/regulator/fixed.h
    index ffd7d50..350edb5 100644
    --- a/include/linux/regulator/fixed.h
    +++ b/include/linux/regulator/fixed.h
    @@ -26,6 +26,12 @@ struct regulator_init_data;
    * @gpio: GPIO to use for enable control
    * set to -EINVAL if not used
    * @startup_delay: Start-up time in microseconds
    + * @gpio_is_open_drain: Gpio pin is open drain or normal type.
    + * If it is open drain then HIGH will be set
    + * through PULL-UP and gpio will be set as input
    + * and low will be set as gpio-output with driven
    + * to low. For non-open-drain case, the gpio will
    + * will be in output and drive to low/high accordingly.
    * @enable_high: Polarity of enable GPIO
    * 1 = Active high, 0 = Active low
    * @enabled_at_boot: Whether regulator has been enabled at
    @@ -43,6 +49,7 @@ struct fixed_voltage_config {
    int microvolts;
    int gpio;
    unsigned startup_delay;
    + unsigned gpio_is_open_drain:1;
    unsigned enable_high:1;
    unsigned enabled_at_boot:1;
    struct regulator_init_data *init_data;
    --
    1.7.1.1


    \
     
     \ /
      Last update: 2012-02-13 07:35    [W:0.023 / U:30.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site