lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] TPM: Nuvoton I2C driver
On Fri, 10 Feb 2012, Stefan Berger wrote:

> On 02/07/2012 08:06 AM, Rajiv Andrade wrote:
> > From: Dan.Morav@nuvoton.com<Dan.Morav@nuvoton.com>
> >
> > Below are the additions for WPCT301/NPCT501 Nuvoton Technology
> > TPM with I2C interface device driver. This driver uses Linux I2C
> > bus driver to interface with the I2C bus and Linux TPM driver (tpm.ko),
> > to export the standard Linux TPM interface. This driver requires an
> > I2C bus driver and TPM driver (tpm.ko) to be loaded prior to its loading.
> > This driver tested on Linux kernel version 3.3 on an x86 based platform.
> >
> > Signed-off-by: Dan Morav<dmorav@nuvoton.com>
> > Signed-off-by: Rajiv Andrade<srajiv@linux.vnet.ibm.com>
> [...]
> > +
> > endif # TCG_TPM
> > diff --git a/drivers/char/tpm/Makefile b/drivers/char/tpm/Makefile
> > index ea3a1e0..064669a 100644
> > --- a/drivers/char/tpm/Makefile
> > +++ b/drivers/char/tpm/Makefile
> > @@ -9,3 +9,4 @@ obj-$(CONFIG_TCG_TIS) += tpm_tis.o
> > obj-$(CONFIG_TCG_NSC) += tpm_nsc.o
> > obj-$(CONFIG_TCG_ATMEL) += tpm_atmel.o
> > obj-$(CONFIG_TCG_INFINEON) += tpm_infineon.o
> > +obj-$(CONFIG_TCG_NUVOTON_I2C) += tpm_nuvoton_i2c.o
> > diff --git a/drivers/char/tpm/tpm_nuvoton_i2c.c b/drivers/char/tpm/tpm_nuvoton_i2c.c
> > new file mode 100644
> > index 0000000..daf0d49
> > --- /dev/null
> > +++ b/drivers/char/tpm/tpm_nuvoton_i2c.c
> > @@ -0,0 +1,718 @@
> > +/******************************************************************************
> > + * Nuvoton TPM I2C Device Driver Interface for WPCT301/NPCT501,
> > + * based on the TCG TPM Interface Spec version 1.2.
> > + * Specifications at www.trustedcomputinggroup.org
>
> Since it's implemented following non-proprietary specs, would this
> driver qualify as the generic tpm_i2c driver or is there anything
> besides the device-id,vendor-id + firmware work-around in the driver
> specific to this particular device implementation.
>
> Regards,
> Stefan

There isn't. There are other i2c TPMs out there though, but my intention is to
keep it all in single tpm_i2c driver in case it's true for them as well.

Rajiv



\
 
 \ /
  Last update: 2012-02-13 17:49    [from the cache]
©2003-2011 Jasper Spaans