lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 0/5] scsi, sd, pm, request based runtime PM for scsi disk
On Mon, 13 Feb 2012, Oliver Neukum wrote:

> Am Montag, 13. Februar 2012, 02:42:24 schrieb Alan Stern:
> > On Sun, 12 Feb 2012, Oliver Neukum wrote:
> >
> > > Yes, we can use the same heuristics as everywhere.
> > > command queued -> autopm_get
> > > command finished -> autopm_put
> > >
> > > but for the USB host adapter, not the sr device
> >
> > I still don't fully understand. Are you suggesting that we use the
> > normal autosuspend timeout mechanism for the disk drive (for example,
> > spin down the disk if it hasn't been used for five minutes), and then
>
> Yes. The key here is to realize that from a view point of functionality
> they are not suspended. But they will be ready to be suspended.

We appear to be using the word "suspended" in different ways.

When I say a device is suspended, I mean that dev->power.runtime_status
is set to RPM_SUSPENDED, the subsystem's or driver's runtime_suspend
method has been called, and the driver is not ready to carry out I/O
requests immediately (it would have to call pm_runtime_get first). I
do not necessarily mean that the device is at a low power setting.

It seems that you are using the word "suspended" to mean something
else, but it's hard to tell what. Regardless, let's stick to my
meaning. Once the runtime_suspend method for the drive has returned
successfully, the drive is indeed suspended.

> > autosuspend a USB mass-storage device whenever its children are
> > suspended and no commands are in progress? (In fact, there can't be
> > any commands in progress if all the children are suspended.)
>
> Really? It is currently true because the device must be opened to issue
> commands.
> In fact now that you put it this way, it seems to me that this is the
> preconception we must shed.

It is true because all SCSI commands are directed toward one of the
children, i.e., to a particular LUN. If that LUN is suspended then
its driver won't allow any commands to be sent to it. As you say,
right now this is true because the device file must be opened before
commands can be issued -- but even if we remove that restriction, it
will still be true that commands won't be issued while the device is
suspended.

It's not a preconception; it is a basic design principle of the
kernel's Runtime PM implementation.

> > The SCSI drivers don't know much about the request queue -- the block
> > layer manages it. That's another reason for handling this at the block
> > layer.
>
> That was refering to SCSI requests.

That's the same thing. The SCSI layer doesn't have its own request
queues; it uses the queues provided by the block layer.

Alan Stern



\
 
 \ /
  Last update: 2012-02-13 16:23    [W:0.090 / U:0.628 seconds]
©2003-2014 Jasper Spaans. Advertise on this site