lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/13] firewire-sbp-target: Add Kconfig, Makefile and TODO
From
Date
On Sat, 2012-02-11 at 19:44 +0000, Chris Boot wrote:
> The FireWire SBP-2 Target is a driver for using an IEEE-1394 connection
> as a SCSI transport. This module uses the SCSI Target framework to
> expose LUNs to other machines attached to a FireWire bus, in effect
> acting as a FireWire hard disk similar to FireWire Target Disk mode on
> older Apple computers.
> Signed-off-by: Chris Boot <bootc@bootc.net>
> Cc: Andy Grover <agrover@redhat.com>
> Cc: Clemens Ladisch <clemens@ladisch.de>
> Cc: Nicholas A. Bellinger <nab@linux-iscsi.org>
> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
> drivers/target/sbp/Kconfig | 14 ++++++++++++++
> drivers/target/sbp/Makefile | 13 +++++++++++++
> drivers/target/sbp/TODO | 7 +++++++
> 3 files changed, 34 insertions(+), 0 deletions(-)
> create mode 100644 drivers/target/sbp/Kconfig
> create mode 100644 drivers/target/sbp/Makefile
> create mode 100644 drivers/target/sbp/TODO
>
> diff --git a/drivers/target/sbp/Kconfig b/drivers/target/sbp/Kconfig
> new file mode 100644
> index 0000000..8544010
> --- /dev/null
> +++ b/drivers/target/sbp/Kconfig
> @@ -0,0 +1,14 @@
> +
> +config FIREWIRE_SBP_TARGET
> + tristate "FireWire SBP-2 fabric module"
> + depends on TARGET_CORE && CONFIGFS_FS && FIREWIRE && EXPERIMENTAL
> + default n
> + help
> + Say Y or M here to enable SCSI target functionality over FireWire.
> + This enables you to expose SCSI devices to other nodes on the FireWire
> + bus, for example hard disks. Similar to FireWire Target Disk mode on
> + older Apple computers.
> +
> + To compile this driver as a module, say M here: The module will be
> + called firewire-sbp-target.
> +

Hi Chris,

Just a minor Kconfig related item here. You can go ahead and drop the
extra depends on TARGET_CORE && CONFIGFS_FS here, as
drivers/target/Kconfig is already handling the dependencies for these
two config options before including drivers/target/sbp/Kconfig.

Thanks!

--nab



\
 
 \ /
  Last update: 2012-02-13 13:53    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site