lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug
Hi Joe,

On Sun, Feb 12, 2012 at 10:51:44PM -0800, Joe Perches wrote:
> On Mon, 2012-02-13 at 07:37 +0100, Marcel Holtmann wrote:
> > > No need to obfuscate, just use the normal debugging macro.
> > > Add "\n" to uses, align arguments, coalesce formats.
> > > Fix a typo and fix a bad format extended by a line continuation.
> > what is this patch buying us.
>
> Easier greps of pr_debug.

This depends what are you grepping for: for all usage of pr_debug or only
for bluetooth related debugs ;)

> BT_DBG is just an unnecessary useless wrapper.

I think at some point we need to remove the wrapper and switch to common
debug function like dev_dbg but what is the point just renaming it?

Best regards
Andrei Emeltchenko

>
> > The only useful change would be to move to dev_printk, but we are not
> > there yet.
>
> Maybe dev_dbg, but there isn't always an
> appropriate device * available.
>
> There are many uses of:
> pr_debug("%s ...", (some struct hci_dev *)->name, ...)
>
> that could be something like
>
> hci_dev_dbg((some struct hci_dev *), fmt, ...)
>



\
 
 \ /
  Last update: 2012-02-13 10:23    [W:0.100 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site