lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] PM / Sleep: Remove unnecessary label from suspend_freeze_processes()
Date
From: Rafael J. Wysocki <rjw@sisk.pl>

The Finish label in suspend_freeze_processes() is in fact necessary
and makes the function look more complicated that it really is, so
remove it (along with a few empty lines).

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
The patch is on top of linux-pm/pm-sleep.

Thanks,
Rafael

---
kernel/power/power.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Index: linux/kernel/power/power.h
===================================================================
--- linux.orig/kernel/power/power.h
+++ linux/kernel/power/power.h
@@ -234,16 +234,14 @@ static inline int suspend_freeze_process
int error;

error = freeze_processes();
-
/*
* freeze_processes() automatically thaws every task if freezing
* fails. So we need not do anything extra upon error.
*/
if (error)
- goto Finish;
+ return error;

error = freeze_kernel_threads();
-
/*
* freeze_kernel_threads() thaws only kernel threads upon freezing
* failure. So we have to thaw the userspace tasks ourselves.
@@ -251,7 +249,6 @@ static inline int suspend_freeze_process
if (error)
thaw_processes();

- Finish:
return error;
}


\
 
 \ /
  Last update: 2012-02-11 00:35    [W:0.059 / U:0.384 seconds]
©2003-2014 Jasper Spaans. Advertise on this site