lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 08/55] ARM: OMAP2+: GPMC: fix device size setup
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yegor Yefremov <yegor_sub1@visionsystems.de>

    commit 8ef5d844cc3a644ea6f7665932a4307e9fad01fa upstream.

    following statement can only change device size from 8-bit(0) to 16-bit(1),
    but not vice versa:

    regval |= GPMC_CONFIG1_DEVICESIZE(wval);

    so as this field has 1 reserved bit, that could be used in future,
    just clear both bits and then OR with the desired value

    Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm/mach-omap2/gpmc.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/arch/arm/mach-omap2/gpmc.c
    +++ b/arch/arm/mach-omap2/gpmc.c
    @@ -528,7 +528,13 @@ int gpmc_cs_configure(int cs, int cmd, i

    case GPMC_CONFIG_DEV_SIZE:
    regval = gpmc_cs_read_reg(cs, GPMC_CS_CONFIG1);
    +
    + /* clear 2 target bits */
    + regval &= ~GPMC_CONFIG1_DEVICESIZE(3);
    +
    + /* set the proper value */
    regval |= GPMC_CONFIG1_DEVICESIZE(wval);
    +
    gpmc_cs_write_reg(cs, GPMC_CS_CONFIG1, regval);
    break;




    \
     
     \ /
      Last update: 2012-02-11 00:03    [W:0.023 / U:0.800 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site