lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 42/55] target: Use correct preempted registration sense code
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Marco Sanvido <marco@purestorage.com>

    commit 9e08e34e3735ae057eb3834da3570995811b7eb9 upstream.

    The comments quote the right parts of the spec:

    * d) Establish a unit attention condition for the
    * initiator port associated with every I_T nexus
    * that lost its registration other than the I_T
    * nexus on which the PERSISTENT RESERVE OUT command
    * was received, with the additional sense code set
    * to REGISTRATIONS PREEMPTED.

    and

    * e) Establish a unit attention condition for the initiator
    * port associated with every I_T nexus that lost its
    * persistent reservation and/or registration, with the
    * additional sense code set to REGISTRATIONS PREEMPTED;

    but the actual code accidentally uses ASCQ_2AH_RESERVATIONS_PREEMPTED
    instead of ASCQ_2AH_REGISTRATIONS_PREEMPTED. Fix this.

    Signed-off-by: Marco Sanvido <marco@purestorage.com>
    Signed-off-by: Roland Dreier <roland@purestorage.com>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/target/target_core_pr.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/target/target_core_pr.c
    +++ b/drivers/target/target_core_pr.c
    @@ -3079,7 +3079,7 @@ static int core_scsi3_pro_preempt(
    if (!(calling_it_nexus))
    core_scsi3_ua_allocate(pr_reg_nacl,
    pr_res_mapped_lun, 0x2A,
    - ASCQ_2AH_RESERVATIONS_PREEMPTED);
    + ASCQ_2AH_REGISTRATIONS_PREEMPTED);
    }
    spin_unlock(&pr_tmpl->registration_lock);
    /*
    @@ -3191,7 +3191,7 @@ static int core_scsi3_pro_preempt(
    * additional sense code set to REGISTRATIONS PREEMPTED;
    */
    core_scsi3_ua_allocate(pr_reg_nacl, pr_res_mapped_lun, 0x2A,
    - ASCQ_2AH_RESERVATIONS_PREEMPTED);
    + ASCQ_2AH_REGISTRATIONS_PREEMPTED);
    }
    spin_unlock(&pr_tmpl->registration_lock);
    /*



    \
     
     \ /
      Last update: 2012-02-10 23:59    [W:0.024 / U:60.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site