lkml.org 
[lkml]   [2012]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH RFC v2] slab: introduce kmalloc_array
    From
    On Fri, Feb 10, 2012 at 4:09 PM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
    > On Thu, Feb 9, 2012 at 4:48 PM, Xi Wang <xi.wang@gmail.com> wrote:
    >> -static inline void *kcalloc(size_t n, size_t size, gfp_t flags)
    >> +static inline void *kmalloc_array(size_t n, size_t size, gfp_t flags)
    >>  {
    >>        if (size != 0 && n > ULONG_MAX / size)
    >>                return NULL;
    >> -       return __kmalloc(n * size, flags | __GFP_ZERO);
    >> +       return __kmalloc(n * size, flags);
    >> +}
    >
    > It should be named kaalloc(), I think.
    > Why it is ULONG_MAX, when size_t is used?

    Also, it could be written more "robust" against people who will make
    sizeof() the first argument with __builtin_constant_p().
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-02-10 14:13    [W:0.022 / U:32.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site