Messages in this thread |  | | | Date | Wed, 1 Feb 2012 21:59:49 -0700 | | From | Grant Likely <> | | Subject | Re: [PATCH 1/2 RESEND] gpio: Add missing spin_lock_init in gpio-ml-ioh driver |
| |
On Wed, Feb 01, 2012 at 10:50:05AM +0800, Axel Lin wrote: > This bug was introduced by commit 54be5663 > "gpio-ml-ioh: Support interrupt function" which adds a spinlock to struct > ioh_gpio but never init the spinlock. > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied both, thanks.
g.
> --- > drivers/gpio/gpio-ml-ioh.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c > index 461958f..271fd49 100644 > --- a/drivers/gpio/gpio-ml-ioh.c > +++ b/drivers/gpio/gpio-ml-ioh.c > @@ -448,6 +448,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev, > chip->reg = chip->base; > chip->ch = i; > mutex_init(&chip->lock); > + spin_lock_init(&chip->spinlock); > ioh_gpio_setup(chip, num_ports[i]); > ret = gpiochip_add(&chip->gpio); > if (ret) { > -- > 1.7.5.4 > > >
|  |