Messages in this thread | | | Date | Thu, 2 Feb 2012 02:42:08 +0300 | From | Alexey Dobriyan <> | Subject | Re: [06/20] crypto: sha512 - reduce stack usage to safe number |
| |
On Wed, Feb 01, 2012 at 12:14:08PM -0800, Greg KH wrote: > @@ -87,38 +87,48 @@ sha512_transform(u64 *state, const u8 *i > u64 a, b, c, d, e, f, g, h, t1, t2; > > int i; > - u64 W[80]; > + u64 W[16];
This needs 3rd companion patch which does stack reduction even on i386. Patch which removes excessive loop unrolling and thus fixes the problem has been posted. Maybe there is some other way to maintain low stack space on i386 but I haven't found it.
http://marc.info/?l=linux-netdev&m=132768692525017&w=4
If you apply only 2, original bug will be fixed, but on at least i386 stack usage could go in 900-byte region.
| |