lkml.org 
[lkml]   [2012]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[40/65] drivers/usb/host/ehci-fsl.c: add missing iounmap
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Julia Lawall <Julia.Lawall@lip6.fr>

    commit 2492c6e6454ff3edb11e273b071a6ea80a199c71 upstream.

    Add missing iounmap in error handling code, in a case where the function
    already preforms iounmap on some other execution path.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression e;
    statement S,S1;
    int ret;
    @@
    e = \(ioremap\|ioremap_nocache\)(...)
    ... when != iounmap(e)
    if (<+...e...+>) S
    ... when any
    when != iounmap(e)
    *if (...)
    { ... when != iounmap(e)
    return ...; }
    ... when any
    iounmap(e);
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/host/ehci-fsl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/host/ehci-fsl.c
    +++ b/drivers/usb/host/ehci-fsl.c
    @@ -125,7 +125,7 @@ static int usb_hcd_fsl_probe(const struc
    */
    if (pdata->init && pdata->init(pdev)) {
    retval = -ENODEV;
    - goto err3;
    + goto err4;
    }

    /* Enable USB controller, 83xx or 8536 */



    \
     
     \ /
      Last update: 2012-02-01 22:45    [W:0.020 / U:30.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site