lkml.org 
[lkml]   [2012]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[82/89] USB: cp210x: call generic open last in open
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <jhovold@gmail.com>

    commit 55b2afbb92ad92e9f6b0aa4354eb1c94589280c3 upstream.

    Make sure port is fully initialised before calling generic open.

    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/serial/cp210x.c | 9 ++-------
    1 file changed, 2 insertions(+), 7 deletions(-)

    --- a/drivers/usb/serial/cp210x.c
    +++ b/drivers/usb/serial/cp210x.c
    @@ -393,8 +393,6 @@ static unsigned int cp210x_quantise_baud

    static int cp210x_open(struct tty_struct *tty, struct usb_serial_port *port)
    {
    - int result;
    -
    dbg("%s - port %d", __func__, port->number);

    if (cp210x_set_config_single(port, CP210X_IFC_ENABLE, UART_ENABLE)) {
    @@ -403,13 +401,10 @@ static int cp210x_open(struct tty_struct
    return -EPROTO;
    }

    - result = usb_serial_generic_open(tty, port);
    - if (result)
    - return result;
    -
    /* Configure the termios structure */
    cp210x_get_termios(tty, port);
    - return 0;
    +
    + return usb_serial_generic_open(tty, port);
    }

    static void cp210x_close(struct usb_serial_port *port)



    \
     
     \ /
      Last update: 2012-02-01 22:27    [W:3.934 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site