Messages in this thread | | | Date | Wed, 01 Feb 2012 02:10:02 -0500 (EST) | Subject | Re: [PATCH 6/6] cls_cgroup: remove redundant rcu_read_lock/unlock | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Wed, 01 Feb 2012 08:07:19 +0100
> Then, I wonder why we do the "if (classid && classid != sk->sk_classid)" > > before the : > > sk->sk_classid = classid; > > This seems unnecessary checks. >
Avoiding dirtying the sk->sk_classid cache line unnecessarily?
I actually have no idea actually how often this routine can get invoked in real world scenerios.
| |