Messages in this thread | | | Date | Wed, 1 Feb 2012 21:36:39 +0400 | From | Anton Vorontsov <> | Subject | Re: [PATCH] bq27x00_battery: fix flag register read |
| |
On Thu, Jan 19, 2012 at 02:49:03AM -0800, Pali Rohár wrote: > On Saturday 14 January 2012 22:50:49 Grazvydas Ignotas wrote: > > When reading flags, bq27x00_read() argument is inverted and causes > > reads 2 of bytes for bq27200 and 1 byte for bq27500, while their register > > sizes are 1 and 2 bytes respectively. This causes bq27500 upper flag > > bits always to be returned as 0, causing full charge state to never be > > reported correctly, so fix it. > > > > Cc: Pali Rohár <pali.rohar@gmail.com> > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > Signed-off-by: Grazvydas Ignotas <notasas@gmail.com> > > --- > > drivers/power/bq27x00_battery.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/power/bq27x00_battery.c > > b/drivers/power/bq27x00_battery.c index 98bf567..86decb4 100644 > > --- a/drivers/power/bq27x00_battery.c > > +++ b/drivers/power/bq27x00_battery.c > > @@ -312,7 +312,7 @@ static void bq27x00_update(struct bq27x00_device_info > > *di) struct bq27x00_reg_cache cache = {0, }; > > bool is_bq27500 = di->chip == BQ27500; > > > > - cache.flags = bq27x00_read(di, BQ27x00_REG_FLAGS, is_bq27500); > > + cache.flags = bq27x00_read(di, BQ27x00_REG_FLAGS, !is_bq27500); > > if (cache.flags >= 0) { > > if (!is_bq27500 && (cache.flags & BQ27000_FLAG_CI)) { > > dev_info(di->dev, "battery is not calibrated! ignoring capacity > > values\n"); > > Yes, you are right, this patch fixing flags register reading. > Anton Vorontsov, can you send this patch to linux 3.3?
Applied to battery-urgent.git, thanks guys!
-- Anton Vorontsov Email: cbouatmailru@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |