Messages in this thread | | | Date | Wed, 1 Feb 2012 11:31:55 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] mfd/ab8500: support AB9540 variant |
| |
On Wed, Feb 01, 2012 at 12:02:35PM +0100, Linus Walleij wrote:
> identifier field. If possible, we fall back on auto-detecting > the AB variant. The necessary deviations are factored into > the driver and board data.
This seems a bit weird - I would expect the silicon to be more accurate than user provided platform data. I'd expect the driver to always check the information provided by the device and at least log if there's a difference.
It'd also be easier to review the patch if there was some description of the differences (or there were a series of patches adding parameterisation for relevant things followed by one adding the new device).
| |