lkml.org 
[lkml]   [2012]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] udf: Remove unnecessary OOM messages
On Tue 31-01-12 14:42:10, Joe Perches wrote:
> Per call site OOM messages are unnecessary.
> k.alloc and v.alloc failures use dump_stack().
Thanks. Applied.

Honza

>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> fs/udf/super.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index c09a84d..19111f9 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -948,11 +948,8 @@ static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, u32 index)
> else
> bitmap = vzalloc(size); /* TODO: get rid of vzalloc */
>
> - if (bitmap == NULL) {
> - udf_err(sb, "Unable to allocate space for bitmap and %d buffer_head pointers\n",
> - nr_groups);
> + if (bitmap == NULL)
> return NULL;
> - }
>
> bitmap->s_block_bitmap = (struct buffer_head **)(bitmap + 1);
> bitmap->s_nr_groups = nr_groups;
> --
> 1.7.8.111.gad25c.dirty
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2012-02-01 12:31    [W:0.129 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site