Messages in this thread | | | Date | Wed, 1 Feb 2012 12:28:57 +0100 | From | Jan Kara <> | Subject | Re: [PATCH 4/4] udf: Remove unnecessary OOM messages |
| |
On Tue 31-01-12 14:42:10, Joe Perches wrote: > Per call site OOM messages are unnecessary. > k.alloc and v.alloc failures use dump_stack(). Thanks. Applied.
Honza
> > Signed-off-by: Joe Perches <joe@perches.com> > --- > fs/udf/super.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/fs/udf/super.c b/fs/udf/super.c > index c09a84d..19111f9 100644 > --- a/fs/udf/super.c > +++ b/fs/udf/super.c > @@ -948,11 +948,8 @@ static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, u32 index) > else > bitmap = vzalloc(size); /* TODO: get rid of vzalloc */ > > - if (bitmap == NULL) { > - udf_err(sb, "Unable to allocate space for bitmap and %d buffer_head pointers\n", > - nr_groups); > + if (bitmap == NULL) > return NULL; > - } > > bitmap->s_block_bitmap = (struct buffer_head **)(bitmap + 1); > bitmap->s_nr_groups = nr_groups; > -- > 1.7.8.111.gad25c.dirty > -- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |