lkml.org 
[lkml]   [2012]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: add node physical memory range to sysfs
On Fri, Dec 07, 2012 at 02:34:56PM -0800, Davidlohr Bueso wrote:
> This patch adds a new 'memrange' file that shows the starting and
> ending physical addresses that are associated to a node. This is
> useful for identifying specific DIMMs within the system.
>
> Signed-off-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
> ---
> drivers/base/node.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index af1a177..f165a0a 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -211,6 +211,19 @@ static ssize_t node_read_distance(struct device *dev,
> }
> static DEVICE_ATTR(distance, S_IRUGO, node_read_distance, NULL);
>
> +static ssize_t node_read_memrange(struct device *dev,
> + struct device_attribute *attr, char *buf)
> +{
> + int nid = dev->id;
> + unsigned long start_pfn = NODE_DATA(nid)->node_start_pfn;
> + unsigned long end_pfn = start_pfn + NODE_DATA(nid)->node_spanned_pages;
> +
> + return sprintf(buf, "%#010Lx-%#010Lx\n",
> + (unsigned long long) start_pfn << PAGE_SHIFT,
> + (unsigned long long) (end_pfn << PAGE_SHIFT) - 1);
> +}
> +static DEVICE_ATTR(memrange, S_IRUGO, node_read_memrange, NULL);

As you're adding a new sysfs file, we need a Documentation/ABI/ entry as
well. Yes, the existing ones aren't there already, as Andrew points
out, sorry, but that means you get to document them all :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-12-08 21:01    [W:0.047 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site