Messages in this thread | | | Date | Fri, 7 Dec 2012 09:09:47 +0100 | Subject | Re: [PATCH v2 0/3] gpio: twl4030: Correct status reporting for outputs | From | Linus Walleij <> |
| |
On Thu, Dec 6, 2012 at 11:52 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote:
> As Grant commneted on the first version: > https://lkml.org/lkml/2012/12/5/53 > > Introduce bitfields to cache the directionand output status of the pins so we > can report them correctly. > To do this I did some cleanup within the driver to get rid of the global > variables and moved them under a private structure, changed the locking as well > to protect the bitfield operation. > As a last patch I added a note that the PWMA/B handling should not be in this > driver at all.
This looks good to me: Acked-by: Linus Walleij <linus.walleij@linaro.org>
Since Grant was requesting the changes I'll let him decide to merge.
Yours, Linus Walleij
| |