Messages in this thread | | | Date | Fri, 7 Dec 2012 13:30:18 -0800 | Subject | Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge | From | Yinghai Lu <> |
| |
On Fri, Dec 7, 2012 at 11:32 AM, Bjorn Helgaas <bhelgaas@google.com> wrote: > On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe <myron.stowe@redhat.com> wrote: >> From: Yinghai Lu <yinghai@kernel.org> >> >> > For example, as soon as you put this code in pci_root.c instead of > pci_root_hp.c, it becomes obvious that we're keeping a list of host > bridges in both places, and we probably don't need two lists. And it > seems dubious that acpi_pci_root_hp_init() is an initcall that walks > the namespace looking for host bridges, when acpi_pci_root_add() > already exists and is called for every host bridge.
removed the duplicated interface in following patch.
http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=shortlog;h=refs/heads/for-pci-split-pci-root-hp-2
http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=commitdiff;h=a1d1ef3f5e4932bc672d96dedd11c5d58f7f20f5
| [PATCH] PCI, ACPI: remove acpi_root_bridge in pci_root_hp | | Tang noticed that hotplug through container will not update acpi_root_bridge | list. | | After closely checking, we don't need that for struct for tracking and | could use acpi_pci_root directly.
| |