lkml.org 
[lkml]   [2012]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC PATCH 0/8] remove vm_struct list management
    From
    2012/12/7 Andrew Morton <akpm@linux-foundation.org>:
    > On Fri, 7 Dec 2012 01:09:27 +0900
    > Joonsoo Kim <js1304@gmail.com> wrote:
    >
    >> I'm not sure that "7/8: makes vmlist only for kexec" is fine.
    >> Because it is related to userspace program.
    >> As far as I know, makedumpfile use kexec's output information and it only
    >> need first address of vmalloc layer. So my implementation reflect this
    >> fact, but I'm not sure. And now, I don't fully test this patchset.
    >> Basic operation work well, but I don't test kexec. So I send this
    >> patchset with 'RFC'.
    >
    > Yes, this is irritating. Perhaps Vivek or one of the other kexec
    > people could take a look at this please - if would obviously be much
    > better if we can avoid merging [patch 7/8] at all.

    I'm not sure, but I almost sure that [patch 7/8] have no problem.
    In kexec.c, they write an address of vmlist and offset of vm_struct's
    address field.
    It imply that user for this information doesn't have any other
    information about vm_struct,
    and they can't use other field of vm_struct. They can use *only* address field.
    So, remaining just one vm_struct for vmlist which represent first area
    of vmalloc layer
    may be safe.

    But, kexec people may be very helpful to validate this patch.

    Thanks.


    \
     
     \ /
      Last update: 2012-12-07 14:41    [W:3.778 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site