lkml.org 
[lkml]   [2012]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: Fix sparse warning
On Mon, 19 Nov 2012 16:30:40 +0530
Tushar Behera <tushar.behera@linaro.org> wrote:

> blk_drain_queue is only used in this file, so should be marked static.
>
> Fixes following sparse warning.
>
> block/blk-core.c:361:6: warning: symbol 'blk_drain_queue' was not
> declared. Should it be static?
>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> block/blk-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index a8b1527..5db63eb 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -358,7 +358,7 @@ EXPORT_SYMBOL(blk_put_queue);
> * If not, only ELVPRIV requests are drained. The caller is responsible
> * for ensuring that no new requests which need to be drained are queued.
> */
> -void blk_drain_queue(struct request_queue *q, bool drain_all)
> +static void blk_drain_queue(struct request_queue *q, bool drain_all)
> {
> int i;

nit: the objective of this patch is not to reduce the sparse output; it
is to improve the kernel by giving an unnecessarily-global symbol
static scope.

So a better title is one which describes the code fix. The fact that
sparse happened to detect it is less important. I chose
"block/blk-core.c: make blk_drain_queue() static".


\
 
 \ /
  Last update: 2012-12-07 00:41    [W:0.042 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site