lkml.org 
[lkml]   [2012]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/3] HWPOISON, hugetlbfs: fix RSS-counter warning
    Date
    Memory error handling on hugepages can break a RSS counter, which emits
    a message like "Bad rss-counter state mm:ffff88040abecac0 idx:1 val:-1".
    This is because PageAnon returns true for hugepage (this behavior is
    necessary for reverse mapping to work on hugetlbfs).

    Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
    ---
    mm/rmap.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git v3.7-rc8.orig/mm/rmap.c v3.7-rc8/mm/rmap.c
    index 2ee1ef0..df54ef0 100644
    --- v3.7-rc8.orig/mm/rmap.c
    +++ v3.7-rc8/mm/rmap.c
    @@ -1235,7 +1235,9 @@ int try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
    update_hiwater_rss(mm);

    if (PageHWPoison(page) && !(flags & TTU_IGNORE_HWPOISON)) {
    - if (PageAnon(page))
    + if (PageHuge(page))
    + ;
    + else if (PageAnon(page))
    dec_mm_counter(mm, MM_ANONPAGES);
    else
    dec_mm_counter(mm, MM_FILEPAGES);
    --
    1.7.11.7


    \
     
     \ /
      Last update: 2012-12-05 23:21    [W:4.960 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site