lkml.org 
[lkml]   [2012]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [tpmdd-devel] [PATCH 1/1] TPM: STMicroelectronics ST33 I2C KERNEL 3.x.x
Date
Hi Kent,
>
> Heh, duh, well of course it is. I've now staged everything I'm
> planning on pushing at:
>
> git://github.com/shpedoikal/linux.git tpmdd-12-05-12
>
> Please test and let me know if I missed anything.
>
> Thanks,
> Kent
>
> > Kent
> >

(I'm still writing this on behalf of myself ;)

<pedantic mode on - please don't take it personally>
While I really appreciate you helping Mathias out here, I'm not so sure
whether an offlist discussion of a driver submission is a really good idea.
I did not see any v2 / improvements on list and now it's commited (?!)

There's no need to argue here, I'm fine with this,
but I'd highly appreciate if at least the result is published again in the
future on the mailing list, for proper review.

If the mailfilter got the mails I apologize.
<pedantic mode off>

Can you perhaps post the message to the list, so a proper review is possible?

I thought the Mathias has changed the naming of the files? I don't see that in
your commit.


The version you committed to that branch still has some of the items of my
first review. (e.g.
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.)

-> The (possible) GPL v3 clause has to go away for the kernel, but I'm not a
lawyer.



Thanks,
Peter


\
 
 \ /
  Last update: 2012-12-05 22:01    [W:0.136 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site